-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HttpError: You have exceeded a secondary rate limit. #2204
Comments
This is a duplicate of #843. I suspect that that issue was not fixed properly. I got this error today too just for a small push. I am not sure if semantic-release waits 1 s between two calls, or just 720 ms. You can wait for a couple of minutes and then retry the job. I did it and it helped. |
I think the throttling is currently broken because GitHub's response changed its wording a few months ago. This will be resolved once we resolve semantic-release/github#299. Pull request welcome! |
Curious if this is on the roadmap. This is impacting our releases since we use semantic release. |
Same case here! |
Refactors the client to use [@octokit/plugin-retry](https://www.npmjs.com/package/@octokit/plugin-retry) and [@octokit/plugin-throttling](https://www.npmjs.com/package/@octokit/plugin-throttling) as GitHub occasionally changes it's API and these plugins can abstract those changes away from this module. - Removes `lib/definitions/rate-limit.js` - Adds `lib/definitions/retry.js` and `lib/definitions/throttle.js` to handle retry/throttle settings - Updates tests to be more like GitHub (returing the correct rate limit response headers, etc) Fixes semantic-release#299 and semantic-release/semantic-release#2204 See also semantic-release#480 and semantic-release#378
@semantic-release/github doesn't respect GitHub's rate limiting - it did once but I think GH changed their response type and now it doesn't which means publishing large modules like `@libp2p/interfaces` is a dice roll as to whether it will succeed or not. Here we switch to a temporary fork that uses the `@octokit` plugins for throttling and retrying so it should be more reliable. Refs: semantic-release/semantic-release#2204
@semantic-release/github doesn't respect GitHub's rate limiting - it did once but it looks like GH changed their response type and now it doesn't which means publishing large monorepos like `@libp2p/interfaces` is a dice roll as to whether it will succeed or not. Here we switch to a temporary fork that uses the `@octokit` plugins for throttling and retrying so it should be more reliable. Refs: semantic-release/semantic-release#2204
We've had this issue twice within our team this morning in different repos Both times it received the error |
We're seeing this issue quite often as well. Is there any known work arounds? |
i think if the error cannot prevent, we should have an option to help retry. otherwise, the CI will be totally broken by this error and cannot restart, because the version already created, then the trigger action is missed. and for me, the error happen tyr to search issue: [https://api.github.com/search/issues?](https://api.github.com/search/issues? so is it possible to reduce the Github API invoke by disabling some features? |
What I don't get from this error is that the numbers seems wrong. It always says limit 30 and remaining 29, while in any other example we see limit 1000, remaining 0 (and "used" is often 1005 or similar) when getting the error. A small semantic-release demo repo where I tried to reproduce the error: Example run showing the very small rate limit for
With the builds of the example repo taking only 1 min, I can only get the "used" counter up to 2. Next run it's back to 30. So it more seems to be 30 requests/min. However, when you get the error from GitHub, the remaining + used counters still seem wrong:
Reading the semantic-release/github code it seems it can produce a lot of search requests if there are many commits pushed at the same time? |
😕
https://github.com/containerbase/buildpack/runs/7893136166?check_suite_focus=true |
We had the same, publish to npm registry not happened because of this error and on restart of action It was not publishing already, I guess because finding own commits after the commit, which triggered release. It was telling on restart that: The local branch main is behind the remote one, therefore a new version won't be published. |
In our case we had such headers too
|
Re-running jobs at GitHub Actions for example will check out the same commit again so it will always end up in that error since there will be a commit made by semantic-release (version number bump and possibly update to a changelog file). |
Any update on this? 👀 The issue was reported in version |
Our CI workflows are now failing every time due to this issue. |
Same problem here. However, looks like the release is created, only the "success" step is failing, which makes Github Action report a failure. |
Same issue here. Release gets created in GitHub, but doesn't trigger the followup custom actions on success. |
I have started to get this too, after having used semantic release for a few weeks now. Looks like the PR to follow is semantic-release/github#487 |
Just started to get it here too... |
This triggers the rate limit. See semantic-release/semantic-release#2204
This triggers the rate limit. See semantic-release/semantic-release#2204
This triggers the rate limit. See semantic-release/semantic-release#2204
This triggers the rate limit. See semantic-release/semantic-release#2204
This triggers the rate limit. See semantic-release/semantic-release#2204
This triggers the rate limit. See semantic-release/semantic-release#2204
I'm getting this error randomly on my project |
@foxhound87 this is currently the work-around. |
@beiertu-mms thank you. where should add that config? |
@foxhound87 it depends on how you configure it.
|
## [1.1.1](v1.1.0...v1.1.1) (2023-04-27) ### Bug Fixes * **ci:** prevent semantic-release hitting secondary rate limit ([639802d](639802d)), closes [/github.com/semantic-release/semantic-release/issues/2204#issuecomment-1486299917](https://github.com//github.com/semantic-release/semantic-release/issues/2204/issues/issuecomment-1486299917) ### Performance Improvements * run processUploadedFiles at middleware level ([f0dd353](f0dd353))
This is a work-around to stop the rate limit issue when publishing. You can check the issue here semantic-release/semantic-release#2204
) * docs(readme): update README to include the minimum node.js version * ci(release): stop adding comments to issues This is a work-around to stop the rate limit issue when publishing. You can check the issue here semantic-release/semantic-release#2204
See semantic-release/semantic-release#2204 Signed-off-by: Will Soto <willsoto@users.noreply.github.com>
not the exact same error as from semantic-release/semantic-release#2204, but still related to github search api: https://github.com/lydavid/MusicSearch/actions/runs/6994231825/job/19027738803
This triggers the rate limit. See semantic-release/semantic-release#2204
disable semantic release success comments to fix Github rate limits as suggested here: semantic-release/semantic-release#2204 (comment)
What would be great is push these at a different server like one that I control so that I can still make the requests to post these comments but do so with a queue and delays. I probably don't need it to be posted exactly when the release is being made but some time afterwards |
This triggers the rate limit. See semantic-release/semantic-release#2204
Hitting this bug regularly, we shouldn't have to disable features of this tool for it to work consistently :( |
Same here |
It's being addressed: semantic-release/github#857 |
Current behavior
I got the error when
semantic-release
interacts with GitHub to writesuccess
messagesExpected behavior
The pipeline completes without errors, though I have nothing to suggest how to fix it.
Environment
The text was updated successfully, but these errors were encountered: