feat: add support for NO_PROXY #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fgreinacher
requested changes
Apr 8, 2022
There was a problem hiding this comment.
Tanks @Babbafett, I left some comments.
Also I guess you want to format the code: npm run lint -- --fix
fgreinacher
reviewed
Apr 8, 2022
Co-authored-by: Florian Greinacher <florian@greinacher.de>
fgreinacher
requested changes
Apr 8, 2022
fgreinacher
reviewed
Apr 9, 2022
fgreinacher
approved these changes
Apr 9, 2022
fgreinacher
changed the title
|
🎉 This PR is included in version 9.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
hvanoch
pushed a commit
to hvanoch/semantic-release-gitlab
that referenced
this pull request
Apr 14, 2022
Co-authored-by: Florian Greinacher <florian@greinacher.de> Co-authored-by: Julian Beisert <julianbeisert@googlemail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the MR fulfills these requirements
What kind of change does this MR introduce?
What is the current behavior?
What is the new behavior (if this is a feature change)?
Does this MR introduce a breaking change?
No
Other information
In some cases it requires a web proxy to reach resources through the internet and outside of a company network. This will work when the gitlab Instance is also accessible through the internet, but in some cases the gitlab instance is a self hosted one and is only be reachable within the same network.
In case of that you need a proxy configuration (e.g. through HTTP_PROXY and/or HTTPS_PROXY for your build process with @semantic-release/exec) it would fail to reach the gitlab instance as a combination of proxy and no_proxy is not possible at the moment.
This PR will introduce this option to allow a combination of having HTTP_PROXY/HTTPS_PROXY and NO_PROXY environment variables