Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use numeric project ID for API calls #576

Merged
merged 1 commit into from
Aug 3, 2023
Merged

Conversation

fgreinacher
Copy link
Contributor

Before we used the project path, which can cause issues with some proxy or firewall setups that replace slashes in URLs.

Closes #543

Before we used the project path, which can cause issues with some
proxy or firewall setups that replace slashes in URLs.
@fgreinacher fgreinacher merged commit 7fce590 into master Aug 3, 2023
8 checks passed
@fgreinacher fgreinacher deleted the fix/project-id branch August 3, 2023 19:35
@github-actions
Copy link

github-actions bot commented Aug 3, 2023

🎉 This PR is included in version 12.0.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@JedaiRussia
Copy link

This fix caused the downloaded files to be unavailable.
The assets files url now contains the Project ID instead of the project name, which made the files inaccessible. Manually fixing the link means that the file is available for download.
Perhaps this is our problem with self-hosted GitLab. We decided to roll back to semantic-release/gitlab ver 12.0.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use CI_PROJECT_ID instead of name of the project in API calls
3 participants