Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use project path for API calls again #580

Merged
merged 1 commit into from
Aug 9, 2023
Merged

Conversation

fgreinacher
Copy link
Contributor

@fgreinacher fgreinacher commented Aug 9, 2023

The numeric project ID is not working for all cases and I don't have the capacity right now to think about a generic solution.

People that have issues with the project path can override CI_PROJECT_PATH for the semantic-release invocation.

Reverts #576

Closes #579

/cc @JedaiRussia @gaborauth

@fgreinacher fgreinacher requested a review from a team August 9, 2023 09:41
@fgreinacher fgreinacher changed the title Revert "fix: use numeric project ID for API calls" fix: again use project path for API calls Aug 9, 2023
@fgreinacher fgreinacher changed the title fix: again use project path for API calls fix: use project path for API calls again Aug 9, 2023
@gaborauth
Copy link

I'm sad to hear that, I'm trying to make a private fork for ourself that works for us.

Anyway, thanks for trying (I'm currently on vacation, so I couldn't try it).

@gr2m gr2m merged commit b0357dc into master Aug 9, 2023
8 checks passed
@gr2m gr2m deleted the revert-576-fix/project-id branch August 9, 2023 19:57
@github-actions
Copy link

github-actions bot commented Aug 9, 2023

🎉 This PR is included in version 12.0.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@glanceon
Copy link

I'm sad to hear that, I'm trying to make a private fork for ourself that works for us.

Anyway, thanks for trying (I'm currently on vacation, so I couldn't try it).

Stumbled upon same issue, any updates ?

@gaborauth
Copy link

Stumbled upon same issue, any updates ?

It's released and reverted as I know. So, I created a fork, added a configuration option to use the CI_PROJECT_ID and use it internally.

@fgreinacher
Copy link
Contributor Author

I'd also be open to give #576 another try - I think we just need to make sure to use the numeric project ID only for API resources (below /api/v4) and not for other resources like asset files (https://github.com/semantic-release/gitlab/blob/master/lib/publish.js#L157). Happy to look at a PR for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release asset URLs are incorrect
4 participants