Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression in v17.3.8 (marked-terminal peer dependency) #1784

Closed
thislooksfun opened this issue Feb 8, 2021 · 7 comments · Fixed by #1829
Closed

Regression in v17.3.8 (marked-terminal peer dependency) #1784

thislooksfun opened this issue Feb 8, 2021 · 7 comments · Fixed by #1829
Labels
released

Comments

@thislooksfun
Copy link
Contributor

Current behavior

When installing semantic-release v17.3.8 nom outputs a warning that marked-terminal wants a peer dependency of marked < 2, but 17.3.8 updated marked to v2.0.0.

Expected behavior

It should not warn about incompatible package versions.

Environment

  • semantic-release version: 17.3.8
  • CI environment: N/A
  • Plugins used: N/A
  • semantic-release configuration: N/A
  • CI logs: N/A
thislooksfun added a commit to thislooksfun/svelte-repo-card that referenced this issue Feb 8, 2021
@thislooksfun
chore(package): downgrade semantic-release pending semantic-release/s…
0016b5a 
…emantic-release#1784
@masone masone mentioned this issue Feb 9, 2021
Merged
1 task
@felipecrs
Copy link

This needs to be done at mikaelbr/marked-terminal#64.

@thislooksfun
Copy link
Contributor Author

mikaelbr/marked-terminal#64 was merged into master 2 hrs ago, just waiting on a new release now.

@thislooksfun
Copy link
Contributor Author

Progress towards the new release is being tracked in mikaelbr/marked-terminal#66

@thislooksfun
Copy link
Contributor Author

marked-terminal v4.1.1 has been released which solves this issue.

@gr2m
Copy link
Member

gr2m commented Mar 3, 2021

could you send a PR to bump the minimal version of marked-terminal to v4.1.1?

@thislooksfun thislooksfun mentioned this issue Mar 3, 2021
Merged
@thislooksfun
Copy link
Contributor Author

@gr2m Just opened #1829.

@gr2m gr2m closed this as completed in #1829 Mar 3, 2021
@github-actions
Copy link

github-actions bot commented Mar 3, 2021

🎉 This issue has been resolved in version 17.4.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@talamcol talamcol mentioned this issue Mar 9, 2021
Merged
@talamcol talamcol mentioned this issue Mar 30, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(deps): peer dependecy error with marked-terminal
3 participants
@gr2m @thislooksfun @felipecrs