Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use correct ci branch context #1521

Merged
merged 6 commits into from Jun 25, 2020
Merged

fix: use correct ci branch context #1521

merged 6 commits into from Jun 25, 2020

Conversation

@iamogbz
Copy link
Contributor

@iamogbz iamogbz commented Apr 11, 2020

Tried testing in circleci and got this message

This test run was triggered on the branch undefined, while semantic-release is configured to only publish from publish-e2e, therefore a new version won’t be published.

Note the undefined in the message above

In the env-ci package there are distinct properties that need to be used to the get the correct ci branch context
https://github.com/pvdlg/env-ci/blob/73299d7f729971a2725cff8b582367f108cfb5ea/services/circleci.js#L21-L24

@poteirard
Copy link

@poteirard poteirard commented Jun 25, 2020

Any chance we can merge this? I'm having the same issue in CircleCI. Thanks for the contribution ❤️ /cc @gr2m

gr2m
gr2m approved these changes Jun 25, 2020
Copy link
Member

@gr2m gr2m left a comment

looks good thank you!

@gr2m gr2m merged commit 0f0c650 into semantic-release:master Jun 25, 2020
4 checks passed
@semantic-release-bot
Copy link
Collaborator

@semantic-release-bot semantic-release-bot commented Jun 25, 2020

🎉 This PR is included in version 17.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@gr2m gr2m mentioned this pull request Jun 25, 2020
@iamogbz iamogbz deleted the patch-1 branch Jun 26, 2020
aquariuslt pushed a commit to aquariuslt/semantic-release that referenced this issue Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants