Fix set_locale name collision in around_action filter #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
N0xFF
reviewed
Jun 21, 2019
Method set_locale conflicts with any controller that defines set_locale method, in particular it breaks Rails mailer previews because Rails::MailersController also has set_locale method.
kolen
force-pushed
the
around-action-fix-name-collision
branch
from
1196728
to
14662c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
subdomain_localestarted to break Rails mailer previews after locale selector had been added to it.subdomain_localesets up around action with methodset_locale:subdomain_locale/lib/subdomain_locale/controller.rb
Lines 3 to 5 in 6aaf623
And now
Rails::MailersControlleralso has a method namedset_locale. This, for some reason, causes any requests toRails::MailersControllerto render empty page.Moved filter to filter class.
rake test:allpasses.