Merkle tree expiries #124
Merged
Merkle tree expiries #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cedoor
added
feature 🚀
cedoor
force-pushed
the
feat/root-expirations
branch
from
2fdc26c
to
aa01cd1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR integrates a mechanism to allow currently-generated proofs to be validated for a certain period of time, even when the Merkle tree root has been updated in the meantime. The
merkleTreeExpiriesmapping contains for each group the list of roots with the creation date and the duration after which each root is no longer usable for generating Semaphore proofs. The default value for roots duration is1 hour, but it can also be defined by external users when a group is created.This PR also updates some tree variable names.
Related Issue
#98 #120
Does this introduce a breaking change?
A new parameter for the Merkle tree root has been added to the
verifyProoffunction.