Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add retry to docker pull #163

Closed
wants to merge 2 commits into from
Closed

add retry to docker pull #163

wants to merge 2 commits into from

Conversation

bogyo210
Copy link
Collaborator

No description provided.

sem-service Outdated Show resolved Hide resolved
@shiroyasha
Copy link
Contributor

Looks good.

Please also run it throught shell-check. If OK, shipit.

@bogyo210
Copy link
Collaborator Author

Not sure about the last line, the rest passed:
https://semaphore.semaphoreci.com/jobs/d651e6bd-14c3-4b96-93ad-5cfcffc82ced

@shiroyasha
Copy link
Contributor

@bogyo210 thanks for adding it. My idea with this was:

  • It is not feasable to fix every problem atm
  • We can still use shell-check to limit the number of newly introduced problems.

For the cache script, it is 154 errors atm. I set it incorrectly to 152. Please modify this.

@shiroyasha
Copy link
Contributor

Screen Shot 2020-06-19 at 2 56 22 PM

However, now when I check it, every number is off... Damn... Any idea how to achive this?

I want to set an upper limit for errors to make sure that we are not introducing new ones.

@bogyo210 bogyo210 closed this Jun 19, 2020
@bogyo210
Copy link
Collaborator Author

merged to nb/shellcheck, pr will come from that

@bogyo210 bogyo210 deleted the nb/sem_service_retry branch June 19, 2020 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants