feat: restrict manager permissions

semaphoreui · Sep 17, 2023 · b310333 · b310333
1 parent 985f3f3
commit b310333
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 4 deletions.
diff --git a/db/ProjectUser.go b/db/ProjectUser.go
@@ -20,7 +20,7 @@ const (
 
 var rolePermissions = map[ProjectUserRole]ProjectUserPermission{
 	ProjectOwner:      CanRunProjectTasks | CanManageProjectResources | CanUpdateProject | CanManageProjectUsers,
-	ProjectManager:    CanRunProjectTasks | CanManageProjectResources | CanManageProjectUsers,
+	ProjectManager:    CanRunProjectTasks | CanManageProjectResources,
 	ProjectTaskRunner: CanRunProjectTasks,
 	ProjectGuest:      0,
 }

diff --git a/web/src/App.vue b/web/src/App.vue
@@ -34,6 +34,7 @@
           @error="onError"
           :need-save="needSave"
           :need-reset="needReset"
+          :is-admin="user.admin"
         />
       </template>
     </EditDialog>

diff --git a/web/src/components/UserForm.vue b/web/src/components/UserForm.vue
@@ -24,15 +24,15 @@
       :label="$t('username')"
       :rules="[v => !!v || $t('user_name_required')]"
       required
-      :disabled="formSaving"
+      :disabled="item.external || formSaving"
     ></v-text-field>
 
     <v-text-field
       v-model="item.email"
       :label="$t('email')"
       :rules="[v => !!v || $t('email_required')]"
       required
-      :disabled="formSaving"
+      :disabled="item.external || formSaving"
     ></v-text-field>
 
     <v-text-field
@@ -41,12 +41,13 @@
       type="password"
       :required="isNew"
       :rules="isNew ? [v => !!v || $t('password_required')] : []"
-      :disabled="formSaving"
+      :disabled="item.external || formSaving"
     ></v-text-field>
 
     <v-checkbox
       v-model="item.admin"
       :label="$t('adminUser')"
+      v-if="isAdmin"
     ></v-checkbox>
 
     <v-checkbox
@@ -59,6 +60,9 @@
 import ItemFormBase from '@/components/ItemFormBase';
 
 export default {
+  props: {
+    isAdmin: Boolean,
+  },
   mixins: [ItemFormBase],
   methods: {
     getItemsUrl() {

diff --git a/web/src/views/Users.vue b/web/src/views/Users.vue
@@ -14,6 +14,7 @@
           @error="onError"
           :need-save="needSave"
           :need-reset="needReset"
+          :is-admin="true"
         />
       </template>
     </EditDialog>