fix(api): user management endpoint

semaphoreui · Dec 1, 2020 · cc3a853 · cc3a853
1 parent 4dbe018
commit cc3a853
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/api/router.go b/api/router.go
@@ -141,23 +141,22 @@ func Route() *mux.Router {
 
 	projectAdminAPI := authenticatedAPI.Path("/project/{project_id}").Subrouter()
 	projectAdminAPI.Use(projects.ProjectMiddleware, projects.MustBeAdmin)
-
 	projectAdminAPI.Methods("PUT").HandlerFunc(projects.UpdateProject)
 	projectAdminAPI.Methods("DELETE").HandlerFunc(projects.DeleteProject)
 
 	projectAdminUsersAPI := authenticatedAPI.PathPrefix("/project/{project_id}").Subrouter()
 	projectAdminUsersAPI.Use(projects.ProjectMiddleware, projects.MustBeAdmin)
 	projectAdminUsersAPI.Path("/users").HandlerFunc(projects.AddUser).Methods("POST")
 
-	projectUserManagement := projectAdminAPI.PathPrefix("/users").Subrouter()
+	projectUserManagement := projectAdminUsersAPI.PathPrefix("/users").Subrouter()
 	projectUserManagement.Use(projects.UserMiddleware)
 
 	projectUserManagement.HandleFunc("/{user_id}", projects.GetUsers).Methods("GET", "HEAD")
 	projectUserManagement.HandleFunc("/{user_id}/admin", projects.MakeUserAdmin).Methods("POST")
 	projectUserManagement.HandleFunc("/{user_id}/admin", projects.MakeUserAdmin).Methods("DELETE")
 	projectUserManagement.HandleFunc("/{user_id}", projects.RemoveUser).Methods("DELETE")
 
-	projectKeyManagement := projectAdminAPI.PathPrefix("/keys").Subrouter()
+	projectKeyManagement := projectAdminUsersAPI.PathPrefix("/keys").Subrouter()
 	projectKeyManagement.Use(projects.KeyMiddleware)
 
 	projectKeyManagement.HandleFunc("/{key_id}", projects.GetKeys).Methods("GET", "HEAD")

diff --git a/api/users.go b/api/users.go
@@ -39,7 +39,8 @@ func addUser(w http.ResponseWriter, r *http.Request) {
 	user.Created = db.GetParsedTime(time.Now())
 
 	if err := db.Mysql.Insert(&user); err != nil {
-		panic(err)
+		log.Warn(editor.Username + " is not created: " + err.Error())
+		w.WriteHeader(http.StatusBadRequest)
 	}
 
 	util.WriteJSON(w, http.StatusCreated, user)