github.com/goreleaser/goreleaser not working under Windows

[fiftin]

I have next error when trying run task deps:tools under Windows 10 (go version 1.10):

go/src/github.com/goreleaser/goreleaser/internal/client/github.go:120:22: cannot use release.GetID() (type int64) as type int in return argument
go/src/github.com/goreleaser/goreleaser/internal/client/github.go:132:28: cannot use releaseID (type int) as type int64 in argument to c.client.Repositories.UploadReleaseAsset

I found similar issue: goreleaser/goreleaser#527

[twhiston]

I think we need to switch downloading the binary for goreleaser. Go getting it is clearly too tempremental across systems. But that sucks because of different binaries for different platforms 😞 if anyone has an elegant solution feel free to propose it.

[twhiston]

I guess we can use something similar (or exactly the same) as the script they provide for ci downloads
https://raw.githubusercontent.com/goreleaser/get/master/get

[twhiston]

@strangeman - do you have capacity to take this in the next day or 2? Should be a reasonably quick fix, but i've got really limited time now until the start of next week.

[strangeman]

Yeah, I'll check it out tomorrow.

[strangeman]

I guess we can use something similar (or exactly the same) as the script they provide for ci downloads
https://raw.githubusercontent.com/goreleaser/get/master/get

That's good for Linux, but not solving the problem with Windows.

[strangeman]

I can't see the way, how we can properly automate goreleaser installation in different OSes. My suggestion: remove it from task deps:tools and add a note about manual installation to Contributing.md.

[twhiston]

We can have os specific taskfiles using a suffix.
https://github.com/go-task/task/blob/master/README.md#os-specific-task

I think we would only ever need a windows one as well as Linux and osx can always use the same taskfile in my experience.

I wanted to avoid this but if needs must I'd rather do that than have special case installs that we must do by hand as it is error prone and goes against my devops principles. Automate everything is my work motto 😉

[strangeman]

I hate Windows automation. Ugly Powershell syntax, different PS versions on different Windows releases, ugh.

In my team, we solved 'Windows problem' radically - all Windows users have WSL installed and got the same automation scripts as Linux/Mac users.

[strangeman]

I tested godownloader (https://github.com/goreleaser/godownloader) on Win10 - it creates only bash script :(

Need to use something like that: https://gist.github.com/MarkTiedemann/c0adc1701f3f5c215fc2c2d5b1d5efd3

[twhiston]

I just generally hate windows 😜 I feel really lucky that at work our solution to the windows problem is just 'we dont support it at all' so I havn't used a Windows machine in about 10 years!

I wonder if we can solve this in the taskfile with the os templating options to pick the apprporiate extension and curling the current release version (https://github.com/go-task/task#gos-template-engine), maybe we can even avoid the windows specific taskfile then?

[twhiston]

I gave it a shot at solving this, though I dont love the windows solution that much, because it blocks the install in circleci v2, which is needed for the dockerfile PR

[twhiston]

closing this as #505 was merged