skip goreleaser install on windows and warn #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strangeman
approved these changes
Mar 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal to deal with goreleaser on windows and linux. See #498 for context.
As this is actually quite a difficult issue to solve in an elegant way and
go getwith and without/...causes issues on different versions of linux (current implementation breaking on cirleci and fedora) and windows this PR proposes that we instead curl the binary and install it to$GOPATH/bin.As curl is not possible on windows we unfortunately skip these steps for windows users and instead echo a warning that they must install the tool manually. Additionally this manual step information has been added in the contribution guide.
Please can you check the goreleaser install steps are skipped properly on windows when reviewing.
@fiftin - any thought or input? Is there some one-liner we could use in windows to download and install the binary?