feat: replace packr and add basic cache headers #1784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tboerger
force-pushed
the
embed-and-cache
branch
3 times, most recently
from
29dc20e
to
8b059d1
Compare
tboerger
force-pushed
the
embed-and-cache
branch
from
8b059d1
to
fc28d2a
Compare
Since packr have been deprecated in favor of go:embed for quite some time now I have replaced it with plain go:embed functionality which makes it more future proof. The only downside is that go:embed can use relativ paths only, that's why I have moved the web/dist folder into api/public. Besides that I have refactored the static asset handling which includes basic last modification and cache control headers to improve the cache cache behavior for static assets.
tboerger
force-pushed
the
embed-and-cache
branch
2 times, most recently
from
012b809
to
67954b9
Compare
|
I didn't find any problems in the code. It works like expected. |
fiftin
approved these changes
Mar 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since packr have been deprecated in favor of go:embed for quite some time now I have replaced it with plain go:embed functionality which makes it more future proof.
The only downside is that go:embed can use relativ paths only, that's why I have moved the web/dist folder into api/public.
Besides that I have refactored the static asset handling which includes basic last modification and cache control headers to improve the cache cache behavior for static assets.
Fixes #1780
Fixes #814