Fix the primary key creation queries in v2.2.1 migration #299

galexrt · 2017-03-14T16:01:13Z

I tried to fix the util test but failed in doing so..

Should the PR target the develop or master branch ? (This PR is targeted at the develop branch)

Add id column to task__output table "instead" Print error message in case of database errors

matejkramny · 2017-04-18T15:41:22Z

db/migrations/v2.2.1.sql

@@ -1,27 +1,5 @@
-ALTER TABLE `user` ADD PRIMARY KEY(id)
+ALTER TABLE `project__user` ADD PRIMARY KEY(project_id);


this primary key makes it impossible to add > 1 user to a project since the key structure is a unique key user_id+project_id

Fix the primary key creation queries

afd2a72

Add id column to task__output table "instead" Print error message in case of database errors

matejkramny merged commit 60a6570 into semaphoreui:develop Apr 18, 2017

matejkramny reviewed Apr 18, 2017

View reviewed changes

matejkramny added a commit that referenced this pull request Apr 18, 2017

fix 2.2.1 migration #299

7c04a92

Provide feedback

		@@ -1,27 +1,5 @@
		ALTER TABLE `user` ADD PRIMARY KEY(id)
		ALTER TABLE `project__user` ADD PRIMARY KEY(project_id);