Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move inventory and keys to its own ephimeral temporary directory. #397

Conversation

fernandezvara
Copy link

Since runs needs to pass some files and right now those lives around the playbook directory, this pull request moves those files to a temporary directory generated on the default temp directory of the machines.

It moves inventory and keys to its own temporal directory. On task finalization clean folder and its contents

Partly fixes #328.

@strangeman
Copy link
Contributor

How will it work with #366? Does ioutil.TempDir creates a new directory on each call or reuse the previous directory?

@fernandezvara
Copy link
Author

Have done a test adding the temp code to the one on that pull request merging both PR. It needs a modification:

On the 'listPlaybookHosts' func it needs to modify the route from where the inventory_[task_id] is retrieved from util.Config.TmpPath to t.tmpdir. That will query the right temp directory from each task.

Anytime as soon as the PR from 366 merge I can modify this to meet that requirements.

@twhiston
Copy link
Contributor

@strangeman - happy if i close this in favour of the solution we have been discussing? (tmp dir or other dir and run cron jobs on the machine)

@strangeman
Copy link
Contributor

Yeah

@twhiston twhiston closed this Feb 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make inventory not mandatory
3 participants