Fix crash when new role added to requirements #442
Merged
+6
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the late reply @strangeman . Both the bug and fix are straightforward. I've never used ansible galaxy so I didn't encouter this problem. Good catch! |
|
any chance of this getting merged? It's also an issue I encountered while testing Semaphore |
|
this issue is actually now a blocker to us adopting Semaphore in our company as openshift playbooks require this fix to run at all. I suppose we can always fork it and deploy that version but I would much rather get these fixes into the official repo. |
|
@twhiston for fast start you can take a look at our fork - https://github.com/UnitedTraders/semaphore/tree/ut-prod. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for #441
I just moved
runGalaxy()fromTask RuntoTask Preparestep. @Natanande, can you review it? This bug caused by task concurrency code