Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stdIn hanging issue #449

Merged
merged 1 commit into from
Feb 27, 2018
Merged

Fix stdIn hanging issue #449

merged 1 commit into from
Feb 27, 2018

Conversation

twhiston
Copy link
Contributor

@twhiston twhiston commented Feb 5, 2018

I had an issue with Semaphore where trying to connect to a host that is not already in the known hosts list would ask you if you wished to add them to the known_hosts. This would cause semaphore to be unable to start any other task and a restart would be needed.
With this fix I simply attach a blank string as stdin to the playbook run command, which causes the host key verification to fail in this instance

@twhiston
Copy link
Contributor Author

@strangeman any thoughts on this?

@twhiston twhiston added the 2.5.0 label Feb 16, 2018
@strangeman
Copy link
Contributor

Interesting. I never had this issue, because we use ssh_args = -o StrictHostKeyChecking=no in our ansible.cfg.
Seems like a simple and effective solution.

@twhiston
Copy link
Contributor Author

Thanks for the approval :)

Due to our security policy we cant set StrictHostKeyChecking=no on our Sempahore machine, so this really bites us if asking for a key hangs the whole program. I've been trying to think if just passing an empty string could ever cause any unintended side effects, but i've never experienced any so I think we can call this ready.

@twhiston twhiston merged commit a6699ff into semaphoreui:develop Feb 27, 2018
@twhiston twhiston deleted the fix_stdin_hang branch February 27, 2018 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants