New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Associate .phtml extension to PHP #238
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p4p3r
requested review from
a team,
aryx and
mjambon
and removed request for
a team
March 27, 2024 10:50
Backwards compatibility summary:
|
aryx
approved these changes
Mar 27, 2024
Yes you need a PR in semgrep that update the cli/src/semgrep/semgrep_interface submodule to point to the latest version, |
p4p3r
added a commit
to semgrep/semgrep
that referenced
this pull request
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes PHP application use the .phtml extension, especially for files which contain a mix of html and php code instead of just php.
In the PHP specs, everything that is not within the
<?php
and?>
tags is considered unstructured text:Our grammar seems to follow this rather closely.
Associating .phtml with PHP basically means:
I did some cursory testing on .phtml files to confirm that they parse fine (using pointer from ) and it seems to be the case.
Here's an example of rule for PHP running on a phtml file: https://semgrep.dev/playground/s/d8EkP
make setup && make
to update the generated code after editing a.atd
file (TODO: have a CI check)For example, the Semgrep backend need to still be able to consume data generated
by Semgrep 1.17.0.
See https://atd.readthedocs.io/en/latest/atdgen-tutorial.html#smooth-protocol-upgrades