Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Associate .phtml extension to PHP #10016

Merged
merged 3 commits into from Mar 28, 2024
Merged

Associate .phtml extension to PHP #10016

merged 3 commits into from Mar 28, 2024

Conversation

p4p3r
Copy link
Contributor

@p4p3r p4p3r commented Mar 27, 2024

@p4p3r p4p3r requested review from a team, amchiclet and kopecs and removed request for a team March 27, 2024 13:50
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 27, 2024 •
edited by p4p3r

PR checklist:

  • Purpose of the code is evident to future readers
  • Tests included or PR comment includes a reproducible test plan
  • Documentation is up-to-date
  • A changelog entry was added to changelog.d for any user-facing change
  • Change has no security implications (otherwise, ping security team)

If you're unsure about any of this, please see:

@p4p3r
Copy link
Contributor Author

p4p3r commented Mar 28, 2024

This will close #10009

@p4p3r
Copy link
Contributor Author

p4p3r commented Mar 28, 2024

@kopecs would you mind reviewing again? I added a changelog item.

kopecs
kopecs approved these changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@kopecs kopecs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changelog looks good

@p4p3r p4p3r merged commit 0db46ad into develop Mar 28, 2024
52 checks passed
@p4p3r p4p3r deleted the claudio/phtml branch March 28, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kopecs kopecs kopecs approved these changes

@amchiclet amchiclet Awaiting requested review from amchiclet amchiclet was automatically assigned from semgrep/pa

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@p4p3r @kopecs