Allow year in OWASP string for scalar type #2867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The regex for scalar strings and lists are different. - Before this change scalar strings did not allow specifying a year, whilst lists must have a year. - After this change a single string may (optionally) have a year, list behaviour is unchanged, a year must be specified.
0xDC0DE
approved these changes
Apr 12, 2023
- I noticed original rule's regex cared about leading zeros. - Restored old behaviour of leading zeros. - Scalar string and list now have consistent behaviour of caring about leading zeros when year is specified. - Scalar string leading year is optional when no year is specified. - Updated test cases.
- Old regex allowed double-zero with year
|
I couldn't reproduce the returntocorp/semgrep:1.0.0 failure, it works fine for me. Looking into the rules I noticed that in the list regex cared about leading zeros. So, I've updated the tests cases and regexs to have matching consistent behaviour of caring about leading zeros. I also noticed the old regex allowed double zero as in I've added more test cases for these. |
|
Don't worry about the historical tests. They are not required, and I believe not cause by your PR at the moment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't changing the lists regex to make years optional (e.g. use the same regex for strings and lists of strings). I figured when specifying multiple OWASP references, it's probably the one category mapped to different years, rather than several categories from a single year. I think years been mandatory is probably a good thing.