Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow year in OWASP string for scalar type #2867

Merged
merged 3 commits into from
Apr 17, 2023
Merged

Allow year in OWASP string for scalar type #2867

merged 3 commits into from
Apr 17, 2023

Commits on Apr 12, 2023

  1. Allow year in OWASP string for scalar type 

    - The regex for scalar strings and lists are different.
- Before this change scalar strings did not allow specifying a year,
  whilst lists must have a year.
- After this change a single string may (optionally) have a year, list
  behaviour is unchanged, a year must be specified.
    @ben-elttam
    ben-elttam committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    6a55bfc View commit details
    Browse the repository at this point in the history

  2. Update metadata-owasp regex 

    - I noticed original rule's regex cared about leading zeros.
- Restored old behaviour of leading zeros.
- Scalar string and list now have consistent behaviour of caring about
  leading zeros when year is specified.
- Scalar string leading year is optional when no year is specified.
- Updated test cases.
    @ben-elttam
    ben-elttam committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    b57794a View commit details
    Browse the repository at this point in the history

  3. metadata-owasp more tests 

    - Old regex allowed double-zero with year
    @ben-elttam
    ben-elttam committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    03aff57 View commit details
    Browse the repository at this point in the history