Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webview): remove extra padding #109

Merged
merged 1 commit into from
Apr 24, 2024
Merged

Conversation

bkettle
Copy link
Contributor

@bkettle bkettle commented Mar 14, 2024

Removes extra padding from the webview UI.

setSearchItems has a type error (or did for me), and I think it's unused, so I commented it out

PR checklist:

  • Purpose of the code is evident to future readers
  • Tests included or PR comment includes a reproducible test plan
  • Documentation is up-to-date
  • A changelog entry was for any user-facing change
  • Change has no security implications (otherwise, ping security team)

If you're unsure about any of this, please see:

@semgrep-zcs-prod-semgrep
Copy link

Semgrep found 2 handle-localstorage-errors findings:

We might not have access to localStorage, so we need to catch exceptions that come from these calls

Ignore this finding from handle-localstorage-errors.

Semgrep found 1 no_console_logs-20220113-201024-16318 finding:

  • src/webview-ui/src/utilities/vscode.ts

Do not commit debugging console.log statements in code that is deployed.

Ignore this finding from no_console_logs-20220113-201024-16318.

Base automatically changed from brandon/streaming-search to master April 24, 2024 22:03
@brandonspark brandonspark merged commit da7f911 into master Apr 24, 2024
10 checks passed
@brandonspark brandonspark deleted the bk/remove-padding branch April 24, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants