Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finish Parse_ocaml_tree_sitter.ml #2885

Closed
mjambon opened this issue Apr 5, 2021 · 3 comments
Closed

Finish Parse_ocaml_tree_sitter.ml #2885

mjambon opened this issue Apr 5, 2021 · 3 comments
Assignees
@aryx
Labels
lang:ocaml priority:low user:internal requested only by someone within Semgrep Inc.

Comments

@mjambon
Copy link
Member

mjambon commented Apr 5, 2021 •
edited

We'd like to use some of the features of OCaml that have been added over the last 10 years or so, such as type id = private int. Currently we're blocked because semgrep doesn't support them and we use semgrep on our own code base, resulting in semgrep errors during CI.

Alternatively we could:

  • tolerate semgrep parsing failures
  • not run semgrep at all on our OCaml code
  • not use any recent OCaml syntax (current situation)
@mjambon mjambon added priority:low lang:ocaml user:internal requested only by someone within Semgrep Inc. labels Apr 5, 2021
@aryx aryx mentioned this issue Apr 11, 2021
Merged
@aryx aryx changed the title Upgrade OCaml grammar in pfff Upgrade OCaml grammar in pfff or tree_sitter Apr 14, 2021
aryx added a commit that referenced this issue Apr 14, 2021
@aryx
[OCaml] add semgrep-ocaml
cd6ea96 
This will help #2885

test plan:
```
$ semgrep-core -dump_tree_sitter_cst tests/ocaml/concrete_syntax.ml
|
|
...
```
@aryx aryx mentioned this issue Apr 14, 2021
Merged
1 task
aryx added a commit that referenced this issue Apr 14, 2021
@aryx
[OCaml] add semgrep-ocaml (#2940)
162f1b0 
* [OCaml] add semgrep-ocaml

This will help #2885

test plan:
```
$ semgrep-core -dump_tree_sitter_cst tests/ocaml/concrete_syntax.ml
|
|
...
```

* adding important files, hmmm
aryx added a commit to semgrep/pfff that referenced this issue Apr 19, 2021
@aryx
[ML] refactor Bool and Unit
d64ab36 
This will help semgrep/semgrep#2885

test plan:
make test
aryx added a commit that referenced this issue Apr 19, 2021
@aryx
[OCaml] fixing literal for Parse_ocaml_tree_sitter.ml
39f1c88 
This will help #2885

test plan:
make test
@aryx aryx mentioned this issue Apr 19, 2021
Merged
1 task
aryx added a commit that referenced this issue Apr 19, 2021
@aryx
[OCaml] fixing literal for Parse_ocaml_tree_sitter.ml (#2966)
242bd3d 
This will help #2885

test plan:
make test
@stale
Copy link

stale bot commented Jul 13, 2021

This issue is being marked stale because there hasn't been any activity in 30 days. Please leave a comment if you think this issue is still relevant and should be prioritized, otherwise it will be automatically closed in 7 days (you can always reopen it later).

@stale stale bot added the stale needs prioritization; label applied by stalebot label Jul 13, 2021
@aryx aryx changed the title Upgrade OCaml grammar in pfff or tree_sitter Finish Parse_ocaml_tree_sitter.ml Jul 13, 2021
@aryx
Copy link
Collaborator

aryx commented Jul 13, 2021

👋

@stale stale bot removed stale needs prioritization; label applied by stalebot labels Jul 13, 2021
aryx added a commit that referenced this issue Jul 23, 2021
@aryx
Parse_ocaml_tree_sitter.ml: fill some todos
d3e25d1 
This will help #2885

test plan:
make
@aryx aryx mentioned this issue Jul 23, 2021
Merged
2 tasks
aryx added a commit that referenced this issue Jul 27, 2021
@aryx
Parse_ocaml_tree_sitter.ml: fill some todos (#3595)
871e7b8 
* Parse_ocaml_tree_sitter.ml: fill some todos

This will help #2885

test plan:
make

* progress

* progress

* progress

* progress

* progress

* progress

* progress

* progress

* progress

* progress

* progress, 38%

* progress

* progress

* progress

* progress

* progress

* progress

* progress

* progress

* progress

* progress

* no more todo!

* fix warnings

* use specific pfff

* use tree-sitter parser for OCaml

* changelog
@aryx
Copy link
Collaborator

aryx commented Sep 13, 2021

Done! (in time for the OCaml workshop 2021).

@aryx aryx closed this as completed Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aryx aryx

Labels
lang:ocaml priority:low user:internal requested only by someone within Semgrep Inc.
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aryx @mjambon