Parse_ocaml_tree_sitter.ml: fill some todos #3595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will help #2885 test plan: make
|
parsing stats for OCaml jump from 25% to 61%, and many projects are >90% correct parsing. |
|
This closes #2885 |
mjambon
reviewed
Jul 26, 2021
| let _v1 = token env v1 (* "(" *) in | ||
| let v2 = str env v2 (* "::" *) in | ||
| let _v3 = token env v3 (* ")" *) in | ||
| v2 |
There was a problem hiding this comment.
It would be great if you could give these variables a name while it's fresh in your mind e.g. let coloncolon = str env v2 in ... coloncolon. Having to figure out their meaning later is tedious.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will help #2885
test plan:
make
PR checklist: