Using DotAccess instead of IdQualified for Python decorators #10221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR checklist:
If you're unsure about any of this, please see: |
aryx
approved these changes
May 8, 2024
semgrep-compare-github-brzbo resultsRan benchmark on 38 repositories The number of files checked differs for 1 repos The number of findings differs for 2 repos Whole benchmark is 0.1% slower (a bit of noise is expected) Relative speed improvement is 1.01 on average
Relative memory improvement is 1.00 on average |
IagoAbal
reviewed
May 9, 2024
| @@ -0,0 +1,3 @@ | |||
| @$X.route(...) | |||
There was a problem hiding this comment.
Didn't this test already work before?
IagoAbal
reviewed
May 9, 2024
| |> G.e) | ||
| base | ||
| in | ||
| G.OtherAttribute |
There was a problem hiding this comment.
TBH I would have added ExprAttr.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test plan:
make testThis PR modifies the translation of Python decorators. In Python, it's generally impossible to distinguish whether a given fully qualified name points to a specific program entity or if it's a field access based on the object instance. Previously, we used
IdQualifiedfor all Python decorators with multiple components separated by dots. However, this approach encountered an issue when attempting to use ametavariable-typefilter on the middle component of the Python decorator. This is becauseIdQualifieddoesn't haveid_infofor itsQDotmiddle component, meaning that the middle component ofIdQualifiedcannot be resolved by the naming phase.To address this problem, we now translate Python decorators into
DotAccessinstead ofIdQualified. Each field name inDotAccesscan be anId, which hasid_info, allowing us to resolve its type information in the naming phase.