clean up yaml memory offset overrides #7931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aryx
approved these changes
Jun 2, 2023
| @@ -11,3 +11,82 @@ YAML_DECLARE(int) | |||
| get_sizeof_yaml_event_t() { | |||
| return sizeof(yaml_event_t); | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
would be nice to add a comment about extra.c in the README about your modification
and what is the purpose of this mysterious print_event.
tpetr
added a commit
that referenced
this pull request
Jun 5, 2023
YAML parsing was fixed in #7918 and #7931, but I didn't catch that node start/end positions were incorrect. This was because in `ctypes_read()` we were returning a JS int when we should have been returning `UInt32` instead. test plan: - confirmed locally that the playground works properly w/ a yaml pattern - added unit test to confirm yaml check works and returns correct positions - `dune build && make test` succeeded
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
print_event()to libyaml so that others can inspect the struct offsets in the futureThis discussion thread has convinced me that the right solution here is to cross-compile, but my opam-fu is weak, so let's continue rolling with my gross hack in the short-term and we can revisit once the dust settles (thanks @yallop for the tips)
test plan: