fix incorrect yaml positions #7946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonspark
approved these changes
Jun 5, 2023
aryx
reviewed
Jun 6, 2023
| @@ -132,8 +132,7 @@ let mk_bracket | |||
| _; | |||
| } ) v env = | |||
| (* The end index needs to be adjusted by one because the token is off *) | |||
| (* TODO: figure out why we get an off-by-one with jsoo *) | |||
| let e_index' = if !Common.jsoo then e_index else e_index - 1 in | |||
| let e_index' = e_index - 1 in | |||
There was a problem hiding this comment.
That's how you realized there was a int32 vs int64 issue with libyaml?
There was a problem hiding this comment.
Not quite, the libyaml 32-bit vs. 64-bit realization was me staring at the memory offsets for long enough, and then realizing that int and size_t are the machine word size.
In this case, the ctypes glue code was incorrectly creating size_t primitives as a JS number when it should have been jsoo's UInt32 type. I didn't immediately catch this issue because the type mismatch resulted in the value being equivalent to zero (in a perfect world an exception would have been thrown)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
YAML parsing was fixed in #7918 and #7931, but I didn't catch that node start/end positions were incorrect. This was because in
ctypes_read()we were returning a JS int when we should have been returningUInt32instead.test plan:
dune build && make testsucceeded