Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing method for small generating set for non-libsemigroups types #865

Closed
james-d-mitchell opened this issue Aug 24, 2022 · 1 comment
Closed
Assignees
Labels
bug Label for issues or PR which report or fix bugs resolved-pending-release A label for issues that are resolved pending a release.

Comments

@james-d-mitchell
Copy link
Collaborator

james-d-mitchell commented Aug 24, 2022

Looking at PR #720 we realised that the option small isn't being honoured any longer for semigroups that satisfy CanUseGapFroidurePin.

gap> S := FreeBand(3);
<free band on the generators [ x1, x2, x3 ]>
gap> S := Semigroup(AsList(S), rec(small := true));
#I  limit = 18446744073709551615
#I  found 9 elements, 3 rules, max word length 1, so far
#I  found 21 elements, 3 rules, max word length 2, so far
#I  found 39 elements, 9 rules, max word length 3, so far
#I  found 69 elements, 9 rules, max word length 4, so far
#I  found 111 elements, 15 rules, max word length 5, so far
#I  found 147 elements, 39 rules, max word length 6, so far
#I  found 159 elements, 45 rules, max word length 7, so far
#I  found 159 elements, 45 rules, max word length 8, finished!
#I  elapsed time: 1,969μs
#I  limit = 8193
#I  found 1 elements, 1 rules, max word length 1, finished!
#I  elapsed time: 20μs
<semigroup with 159 generators>
gap>
@james-d-mitchell james-d-mitchell added the bug Label for issues or PR which report or fix bugs label Aug 25, 2022
@james-d-mitchell james-d-mitchell self-assigned this Aug 25, 2022
@james-d-mitchell james-d-mitchell added this to Todo in Next release via automation Sep 29, 2022
@james-d-mitchell james-d-mitchell moved this from Todo to In progress in Next release Nov 15, 2022
james-d-mitchell added a commit to james-d-mitchell/Semigroups that referenced this issue Nov 15, 2022
This issue was a missing method for ClosureSemigroup for
non-libsemigroups types.
james-d-mitchell added a commit that referenced this issue Nov 15, 2022
This issue was a missing method for ClosureSemigroup for
non-libsemigroups types.
@james-d-mitchell james-d-mitchell moved this from In progress to Done in Next release Nov 15, 2022
@james-d-mitchell james-d-mitchell added the resolved-pending-release A label for issues that are resolved pending a release. label Nov 15, 2022
@james-d-mitchell
Copy link
Collaborator Author

Resolved in v5.2.0

flsmith pushed a commit to flsmith/Semigroups that referenced this issue Mar 1, 2023
This issue was a missing method for ClosureSemigroup for
non-libsemigroups types.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Label for issues or PR which report or fix bugs resolved-pending-release A label for issues that are resolved pending a release.
Projects
Development

No branches or pull requests

1 participant