Add Translations #720

flsmith · 2020-12-02T14:34:49Z

This adds functionality for translations; see the description of #373.

Remaining tasks:

Classify the small number of remaining TODOs
Allow computation of the number of (bi)translations without generating them; most of the code required for this already exists
Complete and correct the documentation

wilfwilson

A few initial comments mostly about the documentation.

wilfwilson · 2020-12-16T15:16:09Z

doc/translat.xml

+gap> mat := [[G.1, G.2], [G.1, G.1], [G.2, G.3]];;
+gap> S := ReesMatrixSemigroup(G, mat);;
+gap> R := Range(RMSNormalization(S));;
+gap> G := UnderlyingSemigroup(R);;


Suggested change

gap> G := UnderlyingSemigroup(R);;

You can delete this line because normalising a RMS/RZMS doesn't change its underlying (semi)group. So here G is still defined as it was a few lines above.

wilfwilson · 2020-12-16T15:18:07Z

tst/extreme/translat.tst

+#
+gap> SEMIGROUPS.StartTest();
+
+#T# RZMS Translational Hull


In the intervening years we've got rid of these #T# and #E# tags, so we may as well not reintroduce them now. So please just use #. 🙂 Same with the standard test file.

wilfwilson · 2020-12-16T15:19:31Z

doc/z-chap14.xml

+    <Heading>
+      Translations and translational hulls
+    </Heading>
+    In this section we describe the functionality in Semigroups for working with


Suggested change

In this section we describe the functionality in Semigroups for working with

In this section we describe the functionality in &Semigroups; for working with

wilfwilson · 2020-12-16T15:40:24Z

doc/translat.xml

+    <Func Name="RightTranslations" Arg="S"/>
+    <Func Name="LeftTranslationsSemigroup" Arg="S"/>
+    <Func Name="RightTranslationsSemigroup" Arg="S"/>
+    <Returns>The semigroup of left or right translations of the given semigroup</Returns>


Suggested change

<Returns>The semigroup of left or right translations of the given semigroup</Returns>

<Returns>A semigroup of left or right translations.</Returns>

wilfwilson · 2020-12-16T15:41:43Z

doc/translat.xml

+    <Func Name="RightTranslation" Arg="R, map"/>
+    <Returns>A left or right translation.</Returns>
+    <Description>
+      For the semigroup of left of right translations and a Mapping on the 


Suggested change

For the semigroup of left of right translations and a Mapping on the

For the semigroup of left of right translations and a mapping on the

? Or do you deliberately want the capital letter for some reason?

wilfwilson · 2020-12-16T15:42:06Z

doc/translat.xml

+      For the semigroup of left of right translations and a Mapping on the 
+      underlying semigroup, or a transformation acting on the indices of the
+      canonical list of elements of the underlying semigroup,
+      LeftTranslation and RightTranslation return the corresponding translations. 


Suggested change

LeftTranslation and RightTranslation return the corresponding translations.

<C>LeftTranslation</C> and <C>RightTranslation</C> return the corresponding translations.

wilfwilson · 2020-12-16T15:44:53Z

doc/translat.xml

+    <Returns>The element of the translational hull corresponding to the given 
+              left and right translations</Returns>


Just to point out, I could be wrong, but we usually use the <Returns> tag to say what kind of GAP object is returned, rather than its mathematical meaning. So this might be more in keeping as:

Suggested change

<Returns>The element of the translational hull corresponding to the given

left and right translations</Returns>

<Returns>A translational hull element.</Returns>

wilfwilson · 2020-12-16T15:45:34Z

doc/translat.xml

+    <Filt Name="IsTranslationalHull" Type="synonym"/>
+    <Description>
+      <C>IsTranslationalHull</C> is a synonym for <C>IsSemigroup</C> and
+      <Ref Filt="IsBitranslationCollection"/>


Suggested change

<Ref Filt="IsBitranslationCollection"/>

<Ref Filt="IsBitranslationCollection"/>.

wilfwilson · 2020-12-16T15:46:25Z

doc/translat.xml

+
+<#GAPDoc Label="UnderlyingSemigroup">
+  <ManSection>
+    <Attr Name="UnderlyingSemigroup" Arg="S"/>


There is no <Returns> tag here.

james-d-mitchell · 2020-12-19T22:12:09Z

gap/attributes/rms-translat.gd

+##
+# W  rms-translat.gd
+# Y  Copyright (C) 2015-17                                       Finn Smith
+##


Might want update the years here!

flsmith · 2022-07-13T17:33:43Z

The linting on this PR will fail until james-d-mitchell/gaplint#13 is merged/released (or some other solution).

flsmith · 2022-07-19T12:39:58Z

@james-d-mitchell I think this is ready to be looked at

james-d-mitchell

Nice one @flsmith! Subject to the comments in this review, I'm happy with this

gap/attributes/attr.gi

james-d-mitchell · 2022-08-24T14:32:03Z

gap/attributes/rms-translat.gd

+#############################################################################
+##
+
+# The declarations in this file are purposefully undocumented.


With what purpose?

They are internal, which I've noted in the file, but should I also preface them with SEMIGROUPS? I was avoiding doing so just because of how annoying that looks when they are used as filters.

gap/attributes/rms-translat.gi

gap/attributes/translat.gd

tst/extreme/translat.tst

flsmith mentioned this pull request Dec 2, 2020

WIP: Translations #373

Closed

6 tasks

flsmith force-pushed the translat-restricted branch 2 times, most recently from f77aa82 to 2f73bcd Compare December 3, 2020 15:13

wilfwilson reviewed Dec 16, 2020

View reviewed changes

james-d-mitchell reviewed Dec 19, 2020

View reviewed changes

flsmith force-pushed the translat-restricted branch from 4f78843 to c961b97 Compare January 25, 2021 16:02

james-d-mitchell added the hackathon-may-2021 label May 26, 2021

james-d-mitchell removed the hackathon-may-2021 label Dec 2, 2021

flsmith force-pushed the translat-restricted branch 2 times, most recently from 3b08ac4 to d06bdcb Compare June 17, 2022 14:07

james-d-mitchell added new-feature A label for PRs that contain new features major A label for issues or PRs that require a major amount of work or big changes. labels Jun 23, 2022

flsmith force-pushed the translat-restricted branch from 0593c0f to 7eaf553 Compare August 10, 2022 14:34

MT-resource-bot added 15 commits August 10, 2022 16:51

add translations

aa1cd74

lint

5262374

fix manual example

e7fcc0a

minor

4f6978b

some progress implementing better left alg

6ca78e1

left translations backtrack working, not integrated

5f6f02e

new translational hull backtrack not working

e167155

working

ffb72e5

little progress

955f00d

not working

5ff936f

working

8844e60

more progress

28f801c

wednesday afternoon

e758a97

fixes

e42b6dd

stabilised left backtrack implemented

ca756c1

MT-resource-bot added 14 commits August 10, 2022 16:51

improve code coverage

16bf2af

manual fixes

af0a7f4

lint

0bc5fcc

minor fixes

a72369f

doc progress

56f750c

make Bitranslation an operation

db89f81

manual progress

fc01295

more manual changes

f7b9da5

linting

6e7027f

coverage

82cba4a

fix manual examples

2d7db11

add NrXTranslations

bfd5c58

lint

47a58aa

fix test whitespace

3c09408

flsmith force-pushed the translat-restricted branch from 7eaf553 to 3c09408 Compare August 10, 2022 15:53

james-d-mitchell mentioned this pull request Aug 24, 2022

Missing method for small generating set for non-libsemigroups types #865

Closed

james-d-mitchell requested changes Sep 7, 2022

View reviewed changes

MT-resource-bot added 9 commits September 21, 2022 16:38

use PermList in MultiplicationTableWithCanonicalPositions

68e44b3

note that the declarations in rms-translat.gd are internal

907bb18

update header of rms-translat.gi

27c9de7

do something less evil in the RZMSGroupLinkingConditions dive

20bfb25

fix minor issues in rms-translat.gi

05d5a0a

make minor fixes in translat.gd

20d0420

update formatting in extreme translat.tst

e84faed

lint

cb525da

refactor internal functions from rms-translat.gd

bd6cc26

james-d-mitchell added this to Todo in Next release via automation Sep 29, 2022

james-d-mitchell moved this from Todo to In progress in Next release Sep 29, 2022

james-d-mitchell merged commit 054cc00 into semigroups:main Sep 30, 2022

james-d-mitchell moved this from In progress to Done in Next release Sep 30, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Translations #720

Add Translations #720

flsmith commented Dec 2, 2020 •

edited

Loading

wilfwilson left a comment

wilfwilson Dec 16, 2020

wilfwilson Dec 16, 2020

wilfwilson Dec 16, 2020

wilfwilson Dec 16, 2020

wilfwilson Dec 16, 2020

wilfwilson Dec 16, 2020

wilfwilson Dec 16, 2020

wilfwilson Dec 16, 2020

wilfwilson Dec 16, 2020

james-d-mitchell Dec 19, 2020

flsmith commented Jul 13, 2022

flsmith commented Jul 19, 2022

james-d-mitchell left a comment

james-d-mitchell Aug 24, 2022

flsmith Sep 21, 2022

	In this section we describe the functionality in Semigroups for working with
	In this section we describe the functionality in &Semigroups; for working with

	<Returns>The semigroup of left or right translations of the given semigroup</Returns>
	<Returns>A semigroup of left or right translations.</Returns>

	For the semigroup of left of right translations and a Mapping on the
	For the semigroup of left of right translations and a mapping on the

	LeftTranslation and RightTranslation return the corresponding translations.
	<C>LeftTranslation</C> and <C>RightTranslation</C> return the corresponding translations.

		<Returns>The element of the translational hull corresponding to the given
		left and right translations</Returns>

	<Returns>The element of the translational hull corresponding to the given
	left and right translations</Returns>
	<Returns>A translational hull element.</Returns>

	<Ref Filt="IsBitranslationCollection"/>
	<Ref Filt="IsBitranslationCollection"/>.

Add Translations #720

Add Translations #720

Conversation

flsmith commented Dec 2, 2020 • edited Loading

wilfwilson left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

flsmith commented Jul 13, 2022

flsmith commented Jul 19, 2022

james-d-mitchell left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

flsmith commented Dec 2, 2020 •

edited

Loading