Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[86bzepn0r][dropdown-menu] increased selector specificity for inner shadow in scroll area #1509

Merged
merged 2 commits into from
Jul 12, 2024

Conversation

ilyabrower
Copy link
Contributor

Motivation and Context

I've fixed selector specificity for inner shadow in scroll area

How has this been tested?

Manually

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Nice improve.

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly or it's not required.
  • Unit tests are not broken.
  • I have added changelog note to corresponding CHANGELOG.md file with planned publish date.
  • I have added new unit tests on added of fixed functionality.

@ilyabrower ilyabrower self-assigned this Jul 10, 2024
@msereniti
Copy link
Contributor

I feel like that all of that css specificity juggling is very fragile. Can you cover it with a screenshot test?

@ilyabrower ilyabrower force-pushed the fix/dropdown-inner-scroll-shadow branch from e13c8ed to dcbe532 Compare July 12, 2024 19:31
@ilyabrower ilyabrower merged commit 7834d3e into master Jul 12, 2024
2 checks passed
@ilyabrower ilyabrower deleted the fix/dropdown-inner-scroll-shadow branch July 12, 2024 19:37
@ilyabrower
Copy link
Contributor Author

I feel like that all of that css specificity juggling is very fragile. Can you cover it with a screenshot test?

I've added snapshot test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants