Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added PHP 8 support; dropped Travis and Coveralls; use Github Actions from now on #145

Merged
merged 26 commits into from Dec 9, 2020

Conversation

k00ni
Copy link
Collaborator

@k00ni k00ni commented Jul 9, 2020

This pull request was about Travis and Code Coverage originally.

But Travis was extremely slow when running ARC2 tests and it took hours before one of the tests even started (December 3th and 4th 2020). It was new to me. To be more independent from other services as well as get faster test results I abandoned Travis as well as Coveralls support.

Also added PHP 8 support.

k00ni added 6 commits July 9, 2020 10:33
before this change, each phpunit run generated a coverage report, which
is time consuming and not neccessary.

now it should be faster because the report is only generated once.

extended composer.json with script section for commands run in Travis.
@coveralls
Copy link

coveralls commented Jul 9, 2020

Pull Request Test Coverage Report for Build 132

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.5%) to 38.357%

Files with Coverage Reduction New Missed Lines %
src/ARC2/Store/Adapter/mysqliAdapter.php 1 71.62%
src/ARC2/Store/Adapter/PDOAdapter.php 1 92.11%
Totals Coverage Status
Change from base Build 124: -0.5%
Covered Lines: 2998
Relevant Lines: 7816

💛 - Coveralls

@k00ni k00ni self-assigned this Jul 22, 2020
@k00ni
Copy link
Collaborator Author

k00ni commented Dec 4, 2020

@semsol I finished this PR, can you have a (short) look please? Thanks in advance.

@k00ni k00ni changed the title Refinements in .travis.yml; added coveralls to composer; added PHP nightly to .travis.yml Refinements in .travis.yml; added coveralls to composer; added PHP 8 support Dec 4, 2020
@k00ni k00ni changed the title Refinements in .travis.yml; added coveralls to composer; added PHP 8 support Added PHP 8 support; removed travis and coveralls usage Dec 4, 2020
@k00ni
Copy link
Collaborator Author

k00ni commented Dec 4, 2020

I updated my initial post. Github Actions result can be found here: https://github.com/semsol/arc2/actions

@k00ni k00ni changed the title Added PHP 8 support; removed travis and coveralls usage Added PHP 8 support; dropped Travis and Coveralls; use Github Actions from now on Dec 4, 2020
@k00ni k00ni merged commit d3e2114 into master Dec 9, 2020
@k00ni k00ni deleted the pr/php-8 branch December 9, 2020 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants