API: Transaction result included in getTransaction #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For now, we'll just add it if you get a transaction directly. If you are receiving a block, we'll just return the transaction itself still need to make sure we have non-null marshalling, or bifurcate the result type, so WIP
orogvany
changed the title
Also add gas/gasPrice to tx/pending
|
@honeycrypto if you use this code, should allow you to get further with chain explorer changes |
orogvany
changed the title
|
Status of the CALL seems to be always |
|
Testnet explorer now shows Gas Used / Gas Limit, Gas Price and Actual TX Cost SEM/USD: |
|
Yeah. It's weird. The contract does succeed and not throw error even if it fails. Not sure if that's by design for erc20, or just a bad demo contract. Will dig deeper. Did verify the VM says it's a success (but did not transfer anything) |
mdodong
approved these changes
Dec 11, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you request an individual transaction, we'll return the full object with transactionResult included.
if you are retrieving a block, we just leave it as a simple transaction without results as before. We can change this in the future, but seems preferrable to prefer lighter weight calls unless necessary.
Also add gas information (gas, gasPrice, gasUsed) so that blockchain explorers can accurately show this along with calculating out actual fee (gasUsed*gasPrice)