Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect Example 10 #249

Closed
thbwd opened this issue Mar 26, 2015 · 1 comment
Closed

Incorrect Example 10 #249

thbwd opened this issue Mar 26, 2015 · 1 comment

Comments

@thbwd
Copy link

thbwd commented Mar 26, 2015

Point 10 of the specification says (emphasis added):

Build metadata MAY be denoted by appending a plus sign and a series of dot separated identifiers immediately following the patch or pre-release version. Identifiers MUST comprise _only ASCII alphanumerics and hyphen [0-9A-Za-z-]_. Identifiers MUST NOT be empty.

Then this example follows:

 1.0.0-beta+exp.sha.5114f85

However the identifier contains periods which are not included in [0-9A-Za-z-] nor are they alphanumerics or hyphens.

So is this example incorrect?
@crazedsanity
Copy link

The given example is correct, as it refers explicitely to the identifiers, which are separated by the dots. So exp is valid, sha is valid, and 5114f85 is valid as individual identifers; the full metadata is then exp.sha.5114f85. Hopefully that makes sense.

@thbwd thbwd closed this as completed Mar 31, 2015
@FichteFoll FichteFoll mentioned this issue Feb 20, 2016
Open
matthijskooijman added a commit to matthijskooijman/semver that referenced this issue Mar 10, 2016
@matthijskooijman
Slightly clarify the build metadata section
8d51c63 
Multiple people (semver#291, semver#249, semver#230, semver#293) have missed the fact that the
build metadata can contain multiple *dot-separated* identifers, and were
confused enough to report a bug about the dots present in one of the
examples. This attempts to make it more obvious that multiple
identifiers might be used.

This closes semver#293.
@matthijskooijman matthijskooijman mentioned this issue Mar 10, 2016
Open
matthijskooijman added a commit to matthijskooijman/semver that referenced this issue Jun 11, 2020
@matthijskooijman
Slightly clarify the build metadata section
d7aaef6 
Multiple people (semver#291, semver#249, semver#230, semver#293) have missed the fact that the
build metadata can contain multiple *dot-separated* identifers, and were
confused enough to report a bug about the dots present in one of the
examples. This attempts to make it more obvious that multiple
identifiers might be used.

This closes semver#293.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@crazedsanity @thbwd