Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pre-release and build meta examples contain invalid characters #291

Closed
clphillips opened this issue Jan 27, 2016 · 2 comments
Closed

Pre-release and build meta examples contain invalid characters #291

clphillips opened this issue Jan 27, 2016 · 2 comments

Comments

@clphillips
Copy link

The spec (version 2.0.0) states that:

Identifiers MUST comprise only ASCII alphanumerics and hyphen [0-9A-Za-z-]

Which applies to both pre-release (section 9) and build meta (section 10). However, the examples given include:

1.0.0-alpha.1, 1.0.0-0.3.7 ... 1.0.0-beta+exp.sha.5114f85

These clearly violate the rule as they contain full stops (.), which are not alphanumerics or hyphens (e.g. they fall outside [0-9A-Za-z-]).
@FichteFoll
Copy link

Start reading the two sections at the beginning.

@clphillips
Copy link
Author

MAY be denoted by appending a [hyphen|plus sign] and a series of dot separated identifiers immediately following the patch version

I swear it wasn't there before. ^_^

@FichteFoll FichteFoll mentioned this issue Feb 20, 2016
Open
matthijskooijman added a commit to matthijskooijman/semver that referenced this issue Mar 10, 2016
@matthijskooijman
Slightly clarify the build metadata section
8d51c63 
Multiple people (semver#291, semver#249, semver#230, semver#293) have missed the fact that the
build metadata can contain multiple *dot-separated* identifers, and were
confused enough to report a bug about the dots present in one of the
examples. This attempts to make it more obvious that multiple
identifiers might be used.

This closes semver#293.
@matthijskooijman matthijskooijman mentioned this issue Mar 10, 2016
Open
matthijskooijman added a commit to matthijskooijman/semver that referenced this issue Jun 11, 2020
@matthijskooijman
Slightly clarify the build metadata section
d7aaef6 
Multiple people (semver#291, semver#249, semver#230, semver#293) have missed the fact that the
build metadata can contain multiple *dot-separated* identifers, and were
confused enough to report a bug about the dots present in one of the
examples. This attempts to make it more obvious that multiple
identifiers might be used.

This closes semver#293.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@clphillips @FichteFoll