Skip to content

Commit

Permalink
Fix WF state propagation on partition verification (#1368)
Browse files Browse the repository at this point in the history
* Allow published state as well

* Changelog updated

* Use IVerified to check the status of the analysis

* Give priority to ANALYSIS_DETACHED_STATES check

* Better to always use the analysis object here
  • Loading branch information
ramonski authored and xispa committed May 20, 2019
1 parent 9d71bff commit 9864693
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGES.rst
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ Changelog

**Fixed**

- #1368 Fix WF state propagation on partition verification
- #1367 Clients can see interim values of analyses not yet verified
- #1361 Fix leap sample ID sequence after secondary sample
- #1344 Handle inline images in Results Interpretation
Expand Down
4 changes: 3 additions & 1 deletion bika/lims/workflow/analysisrequest/guards.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
# Some rights reserved, see README and LICENSE.

from bika.lims import api
from bika.lims.interfaces import IVerified
from bika.lims.workflow import isTransitionAllowed

# States to be omitted in regular transitions
Expand Down Expand Up @@ -97,7 +98,8 @@ def guard_verify(analysis_request):
analysis_status = api.get_workflow_status_of(analysis)
if analysis_status in ANALYSIS_DETACHED_STATES:
continue
if analysis_status != 'verified':
# All analyses must be in verified (or further) status
if not IVerified.providedBy(analysis):
return False
analyses_ready = True
return analyses_ready
Expand Down

0 comments on commit 9864693

Please sign in to comment.