Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix WF state propagation on partition verification #1368

Merged
merged 6 commits into from May 20, 2019
Merged

Conversation

ramonski
Copy link
Contributor

Description of the issue/feature this PR addresses

This PR fixes the WF state propagation on the parent sample in the following setup:

  • Sample consists of two partitions
  • First sample was verified and published (all Analyses are in published state)
  • Second sample was verified (all Analyses are in verified state)

The guard currently disallows the verify transition of samples, if not all contained analyses are in the state verified.

However, since we allow partitions, the contained Analyses might be partially in the state published as well.

Current behavior before PR

Parent Sample is stuck in the to_be_verified state

Desired behavior after PR is merged

Parent Sample is transitioned to the verified state automatically and can be published later explicitly.

--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.

@ramonski ramonski requested a review from xispa May 15, 2019 15:15
Copy link
Member

@xispa xispa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point!
@xispa , would be nice to have a test for this specific use case, though

@xispa xispa merged commit 9864693 into master May 20, 2019
@xispa xispa deleted the fix-verify-handler branch May 20, 2019 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants