Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dynamic analysis specification listing error for empty excel columns #1820

Merged
merged 3 commits into from
Jun 23, 2021

Conversation

ramonski
Copy link
Contributor

Description of the issue/feature this PR addresses

This PR fixes an error in the dynamic analysisspec listing when the excel contains empty columns

Current behavior before PR

internal server error occurs

Desired behavior after PR is merged

non string-type columns are filtered out from the folderitems

--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.

@ramonski ramonski requested a review from xispa June 23, 2021 12:27
@xispa xispa merged commit 55c6fc9 into 2.x Jun 23, 2021
@xispa xispa deleted the fix-dynamic-analysisspec-listing branch June 23, 2021 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

2 participants