Fix dynamic analysis specification listing error for empty excel columns (1.3.x) #1825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
``` ERROR Zope.SiteErrorLog 1625760797.610.228053622856 http://localhost:9090/senaite/bika_setup/dynamic_analysisspecs/++add++DynamicAnalysisSpec Traceback (innermost last): Module ZPublisher.Publish, line 138, in publish Module ZPublisher.mapply, line 77, in mapply Module ZPublisher.Publish, line 48, in call_object Module plone.z3cform.layout, line 66, in __call__ Module plone.z3cform.layout, line 50, in update Module plone.dexterity.browser.add, line 118, in update Module plone.z3cform.fieldsets.extensible, line 59, in update Module plone.z3cform.patch, line 30, in GroupForm_update Module z3c.form.group, line 145, in update Module plone.app.z3cform.csrf, line 21, in execute Module z3c.form.action, line 98, in execute Module z3c.form.button, line 315, in __call__ Module z3c.form.button, line 170, in __call__ Module plone.dexterity.browser.add, line 97, in handleAdd Module z3c.form.group, line 98, in extractData Module z3c.form.form, line 148, in extractData Module z3c.form.field, line 324, in extract Module z3c.form.field, line 216, in validate Module z3c.form.validator, line 201, in validate Module z3c.form.validator, line 206, in validateObject Module zope.interface.interface, line 590, in validateInvariants Module bika.lims.content.dynamic_analysisspec, line 69, in validate_sepecs_file TypeError: 'generator' object has no attribute '__getitem__' ```
xispa
changed the title
ramonski
approved these changes
Jul 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses
This Pull Request ports #1820 to 1.3.x and also fixes a TypeError when creating a Dynamic Analysis Specification because of [#1803](#1803 Updated openpyxl to latest Python 2.x compatible version)
Current behavior before PR
Desired behavior after PR is merged
No error
--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.