Simplify attachment render in report options to single checkbox #2262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramonski
changed the title
xispa
approved these changes
Feb 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses
This PR simplifies the attachment "render in report" logic to be a simply checkbox instead of an option field.
This PR also implements the request of senaite/senaite.impress#38
Current behavior before PR
The user can choose between "Render in Report" and "Ignore in Report" which might be confusing.
Desired behavior after PR is merged
There is only a sinlge checkbox if the attachment should be rendered in the report, otherwise it will be ignored.
All valid attachments can be manually attached to the publication email
--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.