Move upgrade step 2418 after 2419 #2263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses
With PR #2262 the schema field
ReportOptionwas removed and a newRenderInReportintroduced.If upgrade step
2418was not yet run, the provided upgrade conversion step2419from #2262 wrote back the original values to the newRenderInReportfield, which means that attachments of invalid/retracted analyses were rendered again in reportsCurrent behavior before PR
Attachments of non-valid analyses are rendered again in the report after
2419was runDesired behavior after PR is merged
Attachments of non-valid analyses are ignored in reports after
2420is run--
I confirm I have tested this PR thoroughly and coded it according to PEP8
and Plone's Python styleguide standards.