Adding mock object to self-inspect while running locally as a web app. #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arthurakay
added a commit
that referenced
this pull request
Mar 27, 2014
Adding mock object to self-inspect while running locally as a web app.
| @@ -11,6 +11,7 @@ | |||
| <script src="bootstrap.js"></script> | |||
| <!-- </x-bootstrap> --> | |||
| <script src="ext/ext-theme-neptune.js"></script> | |||
| <script src="mocks.js"></script> | |||
There was a problem hiding this comment.
@arthurakay I'll have a look how we can add the mock.js only when running grunt dev so the normal grunt build stays clean. What do you think?
There was a problem hiding this comment.
I have it as is so that I can run the index.html from a localhost, for debugging the app itself. Hence the tags inside the JS file... though I'm open to suggestion.
There was a problem hiding this comment.
With a small task we make sure that app/AppInspector/mocks.js is only used when running in dev mode, e.g. via localhost from /app/AppInspector/ or dist/.
We also keep the build clean.
when developing rungrunt devorgrunt watch, this will add themocks.jstoapp/AppInspector/index.htmlanddist/AppInspector/index.html.when building for a release rungruntorgrunt buildthis will clean out usagemocks.js.
|
ok, please forget all I've said and done so far ... my bad :| |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.