When session store not ready, just return 500 #1000
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When session lose efficacy, almost every server will just 500 but if you just call `next()`, not everyone know `req.session` can be empty, and their servers will crash by using `req.session.key`
|
test case! |
|
shouldn't it wait for the store instead? |
|
@rlidwka Also, if the website is under a huge traffic, we can't make all of the requests wait. |
|
sessions has moved to https://github.com/expressjs/session. i've added @dead-horse to the team, so feel free to make changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When session lose efficacy, almost every server will just 500
but if you just call
next(), not everyone knowreq.sessioncan be empty, and their servers will crash by using
req.session.key