Fix parsing of basic auth credentials if the password includes ':'. #331

wants to merge 2 commits into


None yet

3 participants


The current basic auth middleware will incorrect parse "user:password" for if the password includes a colon.

I'd love to see a 1.6.1 with this. :) Thanks.

Sencha Labs member
tj commented Jul 27, 2011

if you dont mind adding a test or two as well that would be great!


Test case added (and dropped the "throw" I had because it broke existing tests). Apologies for not having run the test suite before.

Sencha Labs member
tj commented Jul 29, 2011

one last thing is signing the CLA if you haven't previously

then it's good to go!


Confused. Why is this a CLA for google? Does Google own the IP for Connect?

Sencha Labs member
tj commented Aug 6, 2011

woah, no, haha, my bad wrong link


Did you have a link to an appropriate CLA?


I signed the CLA a while back. Would it be possible to pull this now? :)


kof commented Mar 6, 2013

seems to be a duplicate of #682 which is already merged

@tj tj closed this Mar 26, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment