Fix parsing of basic auth credentials if the password includes ':'. #331

Closed
wants to merge 2 commits into
from

Projects

None yet

3 participants

@trentm

The current basic auth middleware will incorrect parse "user:password" for if the password includes a colon.

I'd love to see a 1.6.1 with this. :) Thanks.

@tj
Sencha Labs member
tj commented Jul 27, 2011

if you dont mind adding a test or two as well that would be great!

@trentm

Test case added (and dropped the "throw" I had because it broke existing tests). Apologies for not having run the test suite before.

@tj
Sencha Labs member
tj commented Jul 29, 2011

one last thing is signing the CLA if you haven't previously http://code.google.com/legal/individual-cla-v1.0.html

then it's good to go!

@trentm

Confused. Why is this a CLA for google? Does Google own the IP for Connect?

@tj
Sencha Labs member
tj commented Aug 6, 2011

woah, no, haha, my bad wrong link

@trentm

Did you have a link to an appropriate CLA?

@trentm

I signed the CLA a while back. Would it be possible to pull this now? :)

Thanks.

@kof
kof commented Mar 6, 2013

seems to be a duplicate of #682 which is already merged

@tj tj closed this Mar 26, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment