Fix parsing of basic auth credentials if the password includes ':'. #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
if you dont mind adding a test or two as well that would be great! |
…st case for colon in password
|
Test case added (and dropped the "throw" I had because it broke existing tests). Apologies for not having run the test suite before. |
|
one last thing is signing the CLA if you haven't previously http://code.google.com/legal/individual-cla-v1.0.html then it's good to go! |
|
Confused. Why is this a CLA for google? Does Google own the IP for Connect? |
|
woah, no, haha, my bad wrong link |
|
Did you have a link to an appropriate CLA? |
|
I signed the CLA a while back. Would it be possible to pull this now? :) Thanks. |
|
seems to be a duplicate of #682 which is already merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current basic auth middleware will incorrect parse "user:password" for if the password includes a colon.
I'd love to see a 1.6.1 with this. :) Thanks.