Build system refactor #480
Conversation
Start upgrading, but a lot left- Will track changes on the rest.
…why not) No more need for cleaning excluded stuff.
Add my email, license, and proper paths for several grunt plugins.
Stick with camelCase, don't recycle vars, no funky line breaks
Missed this earlier-
Switch to processing directly in themes/scss instead of build-dir. Switches default mode to "expanded" (will minify later)
We can uglify on our side, and removes need for uglifier Ruby gem.
* light -> default: Now includes building dependencies (Zepto/jquery-bridge) * Nix "full" — was re-running build several times...
…xing the .7 in jquery and didn't work with how we title extensions)
…neda Conflicts: README.md
|
I like not having to maintain released file in src (requiring build to run the demo). I think we will need to put back "concat task" soon. As I was trying to write some unit tests, I found that it would be better if we factor out some piece into its own files. And, having the build step to reassemble it. I am not sure about including Zepto's touch.js with jQTouch. Sometimes I use third-party library that must use jQuery. For those projects, it might be easier to jQuery first. I was going to upgrade it to grunt 0.4. Thanks for doing it. It is now definitely much cleaner. Thanks a lot! I haven't checked out the source and try. Give me till end of Monday. |
|
No problem on Monday. I was actually planning on looking at testing separately... Might switch to mocha from qunit, and will definitely be doing more building/concating in that area. Also: Just realized the tests are failing, prob because they reference minified versions, will fix that now. Sorry, what do you mean about including Zepto with jQuery? |
Was not firing globally before, this fixes tests.
|
Disregard my comment on that. I misread your email. I thought you wanted to include Zepto's touch in jQT. But, you said you wanted to include our version of touch back into jQT. I like the idea of supporting more touch capacity than zepto. I like how Zepto's touch layout their code. So, the ideal thing to do might be rewriting ours base on theirs. |
|
Great, will do that as a separate PR. If we can make ours a superset of Zepto's, I'll also set our Zepto rake to exclude their touch class and rename it to zepto-optimized.js or something. |
|
Sound good. |
…ter/easier tests), install grunt globally for Travis, use `grunt test` for tests instead of dist.
|
Tests passing again :) |
|
:-) |
|
Didn't able to look at it. Don't let me hold you up. Will attempt to look at it by Thursday. |
This upgrades the current build system to Grunt .4 (being released tomorrow) and converts the Gruntfile to CoffeeScript. Adds Uglify for minification and CSS minification. Much cleaner build/dist directory, and less repetitive tasks. Also adds a
watchcommand (with LiveReload enabled).The only really subjective part of this PR is that I've pulled out all hard-copied source files from the repo, meaning demos will no longer work directly after checking out the repo (must be built first). Let me know if there are objections, but this is a much cleaner way to maintain the source. Full built files will still be available in the download/release of course.