Removed connection close header from http_meta. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nullobject
commented
Jun 8, 2012
nullobject
commented
- This addresses issue PUT over HTTP randomly fails mostlyserious/riak-js#112 where the socket would randomly close.
- Credit to @jroes for this fix.
* This addresses issue mostlyserious#112 where the socket would randomly close. * Credit to @jroes for this fix.
|
I am really hoping that this fix propagates to the official release at npmjs.org. The offending line (which this pull request corrects by removing the close) causes us to lose about 40% of our KV gets when doing a big batch of reads. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.