Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Dockerize sendgrid/rest #73

Merged
merged 2 commits into from
Feb 19, 2020
Merged

feat: Dockerize sendgrid/rest #73

merged 2 commits into from
Feb 19, 2020

Conversation

graystevens
Copy link
Contributor

Fixes

Resolves #45

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • Roughly followed the steps outlined in Take a rest in this docker container #45. Didn't see a clear need to update USAGE.md, so if I am wildly off track with what I have produced here, let me know 😄
  • Example usage in the updated README.md.
  • Included an example script within the docker folder, so that the README.md is easy to follow.

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 2, 2018
@SendGridDX
Copy link

SendGridDX commented Oct 2, 2018

CLA assistant check
All committers have signed the CLA.

@thinkingserious thinkingserious added hacktoberfest difficulty: medium fix is medium in difficulty type: twilio enhancement feature request on Twilio's roadmap labels Oct 4, 2018
@thinkingserious thinkingserious changed the title Dockerize sendgrid/rest feat: Dockerize sendgrid/rest Feb 19, 2020
@thinkingserious thinkingserious merged commit bb57832 into sendgrid:master Feb 19, 2020
@thinkingserious
Copy link
Contributor

Hello @graystevens,

Thanks again for the PR!

We want to show our appreciation by sending you some swag. Could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: medium fix is medium in difficulty status: code review request requesting a community code review or review from Twilio type: twilio enhancement feature request on Twilio's roadmap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Take a rest in this docker container
3 participants