Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include CodeCov in Travis configuration #384

Closed
wants to merge 3 commits into from

Conversation

mkainula
Copy link

Fixes #383

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • Adds Codecov to travis.yml
  • Adds JaCoCo plugin to pom.xml

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 30, 2017
@SendGridDX
Copy link
Collaborator

SendGridDX commented Oct 30, 2017

CLA assistant check
All committers have signed the CLA.

@thinkingserious
Copy link
Contributor

@mkainula

We have not been able to merge your Pull Request, but because you are awesome - we wanted to make sure you could still get a SendGrid Hacktoberfest shirt.

Please go fill out our swag form before Nov 5th and we will send the shirt! (We know that you might have tried this before and it didn’t work, sorry about that!)

You have till Nov 5th to fill out this form in order to get the Hacktoberfest shirt!

Thank you for contributing during Hacktoberfest! We hope to see you in the repos soon! Just so you know, we always give away a SendGrid shirt for your first ever non-Hacktoberfest PR that gets merged.

@mbernier
Copy link
Contributor

@mkainula it looks like the jacoco plugin is causing this to fail. I was thinking that we're using another plugin to run tests - would it be possible to see if that plugin can pass the unitest data to codecov?

@andy-trimble for sanity check, bc this is Java so I am probably incorrect here.

@andy-trimble
Copy link
Contributor

Yeah. That's a weird instrumentation error. It's unclear why it's failing though. It might be a JaCoCo version issue. It might be worth trying it with a different, pinned version.

@mbernier
Copy link
Contributor

@mkainula can you please try a different jacoco plugin version?

@thinkingserious thinkingserious added difficulty: easy fix is easy in difficulty type: twilio enhancement feature request on Twilio's roadmap and removed hacktoberfest labels Sep 28, 2018
@childish-sambino childish-sambino removed the type: twilio enhancement feature request on Twilio's roadmap label Jul 20, 2020
@thinkingserious thinkingserious changed the base branch from master to main July 28, 2020 14:33
@childish-sambino
Copy link
Contributor

Closing due to inactivity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: easy fix is easy in difficulty status: code review request requesting a community code review or review from Twilio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CodeCov support to .travis.yml
7 participants