Fill 'response' property in error instance #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the behavior when using callbacks consistent with the promise counterpart
|
Multiple fests failed with invalid http status response, I don't know why ;( |
|
Thanks again for another PR! The link I sent you on the other pull request will apply here too. We'll just need it signed once. To test locally, please follow steps 3-6 here: https://github.com/sendgrid/sendgrid-ruby/blob/master/CONTRIBUTING.md#initial-setup They are not passing in Travis CI, because the tests only run for those in the SendGrid team. We are fixing that, and for now, after I get your signed CLA, I'll run the tests locally also as part of my pull review. |
thinkingserious
added
type: community enhancement
thinkingserious
added a commit
that referenced
this pull request
Sep 27, 2016
shkabo
pushed a commit
to shkabo/sendgrid-nodejs
that referenced
this pull request
Oct 5, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the behavior when using callbacks consistent with the promise counterpart.
That is, in both cases,
error.responseis present