Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change contentId to content_id #651

Merged
merged 1 commit into from
Jun 14, 2018
Merged

Conversation

taktran
Copy link
Contributor

@taktran taktran commented Jan 10, 2018

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

Updated docs to match the API

As per request body spec
@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Jan 10, 2018
@SendGridDX
Copy link
Collaborator

SendGridDX commented Jan 10, 2018

CLA assistant check
All committers have signed the CLA.

@taktran
Copy link
Contributor Author

taktran commented Jan 10, 2018

Haven't done everything on the checklist yet, but it's a very simple change. Can do it if need be.

contentId didn't work for @sendgrid/mail v6.1.4, but content_id did as per the spec https://sendgrid.com/docs/API_Reference/api_v3.html

Maybe you want to change the nodejs API though.

@thinkingserious
Copy link
Contributor

Thanks @taktran!

This is now on our backlog for review.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Jan 11, 2018
Copy link

@massm90s massm90s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems legit

@thinkingserious
Copy link
Contributor

Thanks for taking the time to review @massm90s.

@clee clee added status: code review complete and removed status: code review request requesting a community code review or review from Twilio labels Feb 13, 2018
@clee
Copy link

clee commented Feb 13, 2018

LGTM

@thinkingserious thinkingserious added difficulty: easy fix is easy in difficulty type: docs update documentation change not affecting the code status: ready for deploy code ready to be released in next deploy and removed status: code review complete labels Feb 27, 2018
@thinkingserious thinkingserious merged commit 3048980 into sendgrid:master Jun 14, 2018
@thinkingserious
Copy link
Contributor

Hello @taktran,

Thanks again for the PR!

We want to show our appreciation by sending you some swag. Could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: easy fix is easy in difficulty status: ready for deploy code ready to be released in next deploy type: docs update documentation change not affecting the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants